netdev - Re: [patch] usb: pegasus: cleanup a couple conditions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 23 Dec 2011 18:15:29 +0200 (EET)
From:	Petko Manolov <petkan@...leusys.com>
To:	Dan Carpenter <dan.carpenter@...cle.com>
cc:	Petko Manolov <petkan@...rs.sourceforge.net>,
	Greg Kroah-Hartman <gregkh@...e.de>, linux-usb@...r.kernel.org,
	netdev@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [patch] usb: pegasus: cleanup a couple conditions

Once i thought 'loopback' may have other significant bits.  Since it 
doesn't look likely anymore i guess the patch is OK.


cheers,
Petko



On Fri, 23 Dec 2011, Dan Carpenter wrote:

> We recently made loopback a bool type instead of an int, so the bitwise
> AND is redundent.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>
>
> diff --git a/drivers/net/usb/pegasus.c b/drivers/net/usb/pegasus.c
> index 908b427..5d99b8c 100644
> --- a/drivers/net/usb/pegasus.c
> +++ b/drivers/net/usb/pegasus.c
> @@ -517,7 +517,7 @@ static inline int reset_mac(pegasus_t *pegasus)
> 	for (i = 0; i < REG_TIMEOUT; i++) {
> 		get_registers(pegasus, EthCtrl1, 1, &data);
> 		if (~data & 0x08) {
> -			if (loopback & 1)
> +			if (loopback)
> 				break;
> 			if (mii_mode && (pegasus->features & HAS_HOME_PNA))
> 				set_register(pegasus, Gpio1, 0x34);
> @@ -561,7 +561,7 @@ static int enable_net_traffic(struct net_device *dev, struct usb_device *usb)
> 		data[1] |= 0x10;	/* set 100 Mbps */
> 	if (mii_mode)
> 		data[1] = 0;
> -	data[2] = (loopback & 1) ? 0x09 : 0x01;
> +	data[2] = loopback ? 0x09 : 0x01;
>
> 	memcpy(pegasus->eth_regs, data, sizeof(data));
> 	ret = set_registers(pegasus, EthCtrl0, 3, data);
>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html