netdev - Re: [PATCH] netem: dont call vfree() under spinlock and BH disabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 24 Dec 2011 16:10:08 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	shemminger@...tta.com
Cc:	eric.dumazet@...il.com, netdev@...r.kernel.org
Subject: Re: [PATCH] netem: dont call vfree() under spinlock and BH disabled

From: Stephen Hemminger <shemminger@...tta.com>
Date: Sat, 24 Dec 2011 11:18:54 -0800

> On Sat, 24 Dec 2011 06:28:51 +0100
> Eric Dumazet <eric.dumazet@...il.com> wrote:
> 
>> commit 6373a9a286 (netem: use vmalloc for distribution table) added a
>> regression, since vfree() is called while holding a spinlock and BH
>> being disabled.
>> 
>> Fix this by doing the pointers swap in critical section, and freeing
>> after spinlock release.
>> 
>> Also add __GFP_NOWARN to the kmalloc() try, since we fallback to
>> vmalloc().
>> 
>> Signed-off-by: Eric Dumazet <eric.dumazet@...il.com>
 ...
> Acked-by: Stephen Hemminger <shemminger@...tta.com>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html