lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 25 Dec 2011 16:30:51 +0100 From: Richard Cochran <richardcochran@...il.com> To: netdev@...r.kernel.org Cc: e1000-devel@...ts.sourceforge.net, Jacob Keller <jacob.e.keller@...el.com>, Jeff Kirsher <jeffrey.t.kirsher@...el.com>, John Ronciak <john.ronciak@...el.com>, John Stultz <john.stultz@...aro.org>, Thomas Gleixner <tglx@...utronix.de> Subject: Re: [PATCH net-next 1/2] igb: add PTP Hardware Clock code Just for the record, reviewing my own patch and pointing out the mistakes WRT the 82576. On Tue, Dec 13, 2011 at 04:00:34AM +0100, Richard Cochran wrote: > +static void igb_82576_systim_write(struct igb_adapter *igb, u64 ns) > +{ > + u32 hi, lo; > + struct e1000_hw *hw = &igb->hw; > + > + hi = (ns >> 8) & 0xffffffff; > + lo = (ns & 0xff) << NS_SHIFT_82576; Should have been: hi = (ns >> 13) & 0xffffffff; lo = (ns & 0x1fff) << NS_SHIFT_82576; > + > + wr32(E1000_SYSTIML, lo); > + wr32(E1000_SYSTIMH, hi); > + > + igb_overflow_set(igb, ns, hi & SYSTIMH_MSB_82576, OFL_SHIFT_82576); > +} -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists