netdev - Re: [PATCH] bonding: document undocumented active

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4EF8FA5F.8010609@gmail.com>
Date:	Mon, 26 Dec 2011 23:51:11 +0100
From:	Nicolas de Pesloüan 
	<nicolas.2p.debian@...il.com>
To:	Jay Vosburgh <fubar@...ibm.com>
CC:	Nicolas de Pesloüan 
	<nicolas.2p.debian@...e.fr>, netdev@...r.kernel.org,
	Andy Gospodarek <andy@...yhouse.net>
Subject: Re: [PATCH] bonding: document undocumented active_slave sysfs entry.

Le 26/12/2011 22:10, Jay Vosburgh a écrit :
> Nicolas de Pesloüan 	<nicolas.2p.debian@...e.fr>  wrote:
>
>> Signed-off-by: Nicolas de Pesloüan<nicolas.2p.debian@...e.fr>
>> cc: Jay Vosburgh<fubar@...ibm.com>
>> cc: Andy Gospodarek<andy@...yhouse.net>
>>
>> ---
>> Documentation/networking/bonding.txt |   14 ++++++++++++++
>> 1 files changed, 14 insertions(+), 0 deletions(-)
>>
>> diff --git a/Documentation/networking/bonding.txt b/Documentation/networking/bonding.txt
>> index 91df678..83b44c2 100644
>> --- a/Documentation/networking/bonding.txt
>> +++ b/Documentation/networking/bonding.txt
>> @@ -196,6 +196,20 @@ or, for backwards compatibility, the option value.  E.g.,
>>
>> 	The parameters are as follows:
>>
>> +active_slave
>> +
>> +	Specifies the active slave for modes that support it (active-backup,
>> +	balance-alb and balance-tlb). The possible values are one of the
>> +	currently enslaved slaves. The selected slave must be up and the
>> +	underlying link must be up too.
>
> 	I would phrase this a bit differently, also including the empty
> string as a possible value:
>
> 	Specifies the new active slave for modes that support it
> 	(active-backup, balance-alb and balance-tlb).  Possible values
> 	are the name of any currently enslaved interface, or an empty
> 	string.  If a name is given, the slave must be up in order to be
> 	selected as the new active slave.  If an empty string is
> 	specified, the current active slave is cleared, and a new active
> 	slave is selected automatically.
>
>> +	Note that this is only available through the sysfs interface. No module
>> +	parameter by that name exists.
> 	
> 	"by this name" instead of "that".
>
>> +	The default value is empty (no active slave). It will automatically be
>> +	set every time an active slave is selected by normal bonding operation.
>> +	The current active slave can be read from this sysfs entry.
>
> 	I'd write this as:
>
> 	The normal value of this option is the name of the currently
> 	active slave, or the empty string if there is no active slave or
> 	the current mode does not use an active slave.
>
> 	With the above changes (or something pretty much equivalent) I'm
> good with this, and you can add a signed-off for me.


Thanks for the review. I will send V2 later.

	Nicolas.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html