netdev - Re: [PATCH] net: fec: Adjust ENET MDIO timeouts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20111227.131344.1087161640480826569.davem@davemloft.net>
Date:	Tue, 27 Dec 2011 13:13:44 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	festevam@...il.com
Cc:	netdev@...r.kernel.org, shawn.guo@...escale.com,
	kernel@...gutronix.de, rogerio.pimentel@...escale.com,
	fabio.estevam@...escale.com
Subject: Re: [PATCH] net: fec: Adjust ENET MDIO timeouts

From: Fabio Estevam <festevam@...il.com>
Date: Tue, 27 Dec 2011 12:46:38 -0200

> -#define FEC_MII_TIMEOUT		1000 /* us */
> +#define FEC_MII_TIMEOUT		30 /* ms */

I don't see why you must use msecs_to_jiffies(), why not just change
FEC_MII_TIMEOUT to 30000?

That's a one-line, easy to validate, change.

Whereas if you also change the units of the timeout I have to go
through the entire driver to audit your patch, making sure none of the
FEC_MII_TIMEOUT uses in the driver have been missed.

When you make multiple changes at once, it leads to more work for the
patch reviewer, please avoid this whenever possible.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html