netdev - Re: [PATCH] skge: restore multicast rx filter on resume

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20111228.130908.182833189468208987.davem@davemloft.net>
Date:	Wed, 28 Dec 2011 13:09:08 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	shemminger@...tta.com
Cc:	florz@...rz.de, netdev@...r.kernel.org
Subject: Re: [PATCH] skge: restore multicast rx filter on resume

From: Stephen Hemminger <shemminger@...tta.com>
Date: Wed, 28 Dec 2011 09:27:14 -0800

> On Wed, 28 Dec 2011 08:41:43 +0100
> Florian Zumbiehl <florz@...rz.de> wrote:
> 
>> Hi,
>> 
>> > > > diff --git a/drivers/net/skge.c b/drivers/net/skge.c
>> > > > index f4be5c7..cd968e5 100644
>> > > > --- a/drivers/net/skge.c
>> > > > +++ b/drivers/net/skge.c
>> > > > @@ -4046,6 +4046,7 @@ static int skge_resume(struct device *dev)
>> > > >  				dev_close(dev);
>> > > >  				goto out;
>> > > >  			}
>> > > > +			skge_set_multicast(dev);
>> > > >  		}
>> > > >  	}
>> > > >  out:
>> > 
>> > Right idea, but it needs to be done in a different spot to catch
>> > all the other device restart cases like changing settings.
>> 
>> Roughly like this maybe? (Successfully tested with an MTU change ...)
>> 
>> Florian
>> 
>> ---------------------------------------------------------------------------
>> skge: restore rx multicast filter on resume
>> 
>> Signed-off-by: Florian Zumbiehl <florz@...rz.de>
>> 
>> diff --git a/drivers/net/skge.c b/drivers/net/skge.c
>> index f4be5c7..8f985a8 100644
>> --- a/drivers/net/skge.c
>> +++ b/drivers/net/skge.c
>> @@ -2587,6 +2587,9 @@ static int skge_up(struct net_device *dev)
>>  	spin_unlock_irq(&hw->hw_lock);
>>  
>>  	napi_enable(&skge->napi);
>> +
>> +	skge_set_multicast(dev);
>> +
>>  	return 0;
>>  
>>   free_rx_ring:
> 
> Looks good. That is (basically) the same as the patch I was testing.
> 
> Acked-by: Stephen Hemminger <shemminger@...tta.com>

Florian, please formally resubmit this with proper changelog and
Stephen's ack.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html