netdev - Re: [PATCH net-next 2/2] mlx4_core: limiting VF port options

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 29 Dec 2011 15:09:59 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	yevgenyp@...lanox.co.il
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next 2/2] mlx4_core: limiting VF port options

From: Yevgeny Petrilin <yevgenyp@...lanox.co.il>
Date: Thu, 29 Dec 2011 19:42:39 +0200

> 
> At the moment VFs can only operate in Eth mode.
> In addition we don't want the VF to attempt link sensing,
> so we block this option as well.
> 
> Signed-off-by: Yevgeny Petrilin <yevgenyp@...lanox.co.il>

Applied, but:

> +#define MLX4_VF_PORT_ETH_ONLY_MASK	0xE6

Why don't you just clearly define what all the port type bits mean
instead of only defining some arbitrary combination of them?

What if people want to experiment with other bit mask settings?  They
can't do that if you don't document the layout fully and properly.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html