netdev - Re: [PATCH] virtio_net: set/cancel work on ndo_open/ndo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20111229.164452.1646856455053448176.davem@davemloft.net>
Date:	Thu, 29 Dec 2011 16:44:52 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	mst@...hat.com
Cc:	rusty@...tcorp.com.au, netdev@...r.kernel.org
Subject: Re: [PATCH] virtio_net: set/cancel work on ndo_open/ndo_stop

From: "Michael S. Tsirkin" <mst@...hat.com>
Date: Thu, 29 Dec 2011 22:33:02 +0200

> On Thu, Dec 29, 2011 at 01:53:52PM +1030, Rusty Russell wrote:
>> Michael S. Tsirkin noticed that we could run the refill work after
>> ndo_close, which can re-enable napi - we don't disable it until
>> virtnet_remove.  This is clearly wrong, so move the workqueue control
>> to ndo_open and ndo_stop (aka. virtnet_open and virtnet_close).
>> 
>> One subtle point: virtnet_probe() could simply fail if it couldn't
>> allocate a receive buffer, but that's less polite in virtnet_open() so
>> we schedule a refill as we do in the normal receive path if we run out
>> of memory.
>> 
>> Signed-off-by: Rusty Russell <rusty@...tcorp.com.au>
> 
> Acked-by: Michael S. Tsirkin <mst@...hat.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html