netdev - Re: [BUG] SIOCSIFFLAGS returns -EIO on SMSC LAN911x

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1325250948.13595.100.camel@deadeye>
Date:	Fri, 30 Dec 2011 14:15:48 +0100
From:	Ben Hutchings <ben@...adent.org.uk>
To:	Javier Martinez Canillas <martinez.javier@...il.com>
Cc:	netdev@...r.kernel.org,
	Enric Balletbo i Serra <eballetbo@...ebcn.com>
Subject: Re: [BUG] SIOCSIFFLAGS returns -EIO on SMSC LAN911x

On Fri, 2011-12-30 at 13:58 +0100, Javier Martinez Canillas wrote:
> On Fri, Dec 30, 2011 at 11:56 AM, Ben Hutchings <ben@...adent.org.uk> wrote:
> > On Fri, 2011-12-30 at 10:44 +0100, Javier Martinez Canillas wrote:
[...]
> >> Did anyone have the same problem?
> >>
> >> The problem is really strange to me, especially since we are sure that
> >> all the requirements to software reset the device are meet in both
> >> cases (with SMSC_PHY compiled built-in and without it)
> >
> > I don't know about that.  smsc_phy_config_init() attempts to enable
> > power-saving on the PHY, but it is writing to a bit that is reserved
> > according to the data sheet for the combined MAC/PHY chip.  dwein
> 
> Since the PHY chip is a lan8700, the power-saving seems to be correct.

But the feature may not be supported in the combined chip, the 9221i.  I
would tend to believe the more specific data sheet.

> But the problem is when latter in the open handler a software reset is
> attempt.
> 
> Probably I can protect the software reset and only try to reset the
> device if the PHY is now in a low power mode. But if we don't reset
> the device at interface bringing up, when should we do a the reset?

You may have to change the order of initialisation of the PHY and MAC so
that reset works properly.

> I'm not that familiarized with the networking layer, if someone can
> give me some light I can fix the issue and send a patch.

This really doesn't have much to do with general networking, only phylib
and the specifics of the SMSC hardware and drivers.  The smsc911x driver
is responsible for calling phylib functions and so the hardware
initialisation is very much under its control.

Ben.

-- 
Ben Hutchings
Beware of programmers who carry screwdrivers. - Leonard Brandwein

Download attachment "signature.asc" of type "application/pgp-signature" (829 bytes)