netdev - Re: [PATCH] fix for nfacct infrastructure in net-next

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 01 Jan 2012 18:02:29 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	pablo@...filter.org
Cc:	netfilter-devel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH] fix for nfacct infrastructure in net-next

From: Pablo Neira Ayuso <pablo@...filter.org>
Date: Sun, 1 Jan 2012 17:23:58 +0100

> On Sun, Jan 01, 2012 at 05:22:24PM +0100, pablo@...filter.org wrote:
>> From: Pablo Neira Ayuso <pablo@...filter.org>
>> 
>> Hi Dave,
>> 
>> Please, pull the following fix for the nfacct infrastructure already
>> in your net-next tree.
>> 
>> You can pull it from:
>> 
>> git://1984.lsi.us.es/net-net nf-next
>                        ^^^^^^^
> I meant to say net-next, of course.

I'm not pulling this.

If I pull from your "corrected" URL, "git://1984.lsi.us.es/net-next nf-next"
it starts to download 17937 objects.  Which means it's going to bring in all
of your -next work as well as my net-next tree upon which it is based, not
just this one bug fix.

These mistakes should never happen in the first place.

If you actually use "git request-pull" to generate the pull request
email body, you can NEVER get the URL wrong, GIT enforces it to be
correct and it enforces that the changes in your local tree are
present at the remote URL as well.

You can't make these kinds of errors and oversights when you want to
ask me to pull in bug fixes at the very last minute when Linus is
about to make a final release.

Just toss these fixes, if they are so important submit them to Greg KH
and the -stable branch after 3.2.0-final goes out.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html