netdev - Re: [PATCH 3/4] input: xilinx_ps2: Don't use NO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120102082148.GE18381@ponder.secretlab.ca>
Date:	Mon, 2 Jan 2012 01:21:48 -0700
From:	Grant Likely <grant.likely@...retlab.ca>
To:	Michal Simek <monstr@...str.eu>
Cc:	linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
	devicetree-discuss@...ts.ozlabs.org,
	Rob Herring <rob.herring@...xeda.com>,
	Ryan Mallon <rmallon@...il.com>
Subject: Re: [PATCH 3/4] input: xilinx_ps2: Don't use NO_IRQ

On Wed, Dec 21, 2011 at 03:32:11PM +0100, Michal Simek wrote:
> Drivers shouldn't use NO_IRQ. Microblaze and PPC
> define NO_IRQ as 0 and this reference will be removed
> in near future.
> 
> Signed-off-by: Michal Simek <monstr@...str.eu>
> CC: Grant Likely <grant.likely@...retlab.ca>
> CC: Rob Herring <rob.herring@...xeda.com>
> CC: Ryan Mallon <rmallon@...il.com>

Acked-by: Grant Likely <grant.likely@...retlab.ca>

> ---
>  drivers/input/serio/xilinx_ps2.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/input/serio/xilinx_ps2.c b/drivers/input/serio/xilinx_ps2.c
> index d64c5a4..f3e54b9 100644
> --- a/drivers/input/serio/xilinx_ps2.c
> +++ b/drivers/input/serio/xilinx_ps2.c
> @@ -253,7 +253,7 @@ static int __devinit xps2_of_probe(struct platform_device *ofdev)
>  	}
>  
>  	/* Get IRQ for the device */
> -	if (of_irq_to_resource(ofdev->dev.of_node, 0, &r_irq) == NO_IRQ) {
> +	if (!of_irq_to_resource(ofdev->dev.of_node, 0, &r_irq)) {
>  		dev_err(dev, "no IRQ found\n");
>  		return -ENODEV;
>  	}
> -- 
> 1.7.5.4
> 
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html