netdev - Re: [PATCH] r6040: use an unique MDIO bus name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20120102.154930.1761330488764990513.davem@davemloft.net>
Date:	Mon, 02 Jan 2012 15:49:30 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	florian@...nwrt.org
Cc:	netdev@...r.kernel.org, vova.kolpakov@...il.com
Subject: Re: [PATCH] r6040: use an unique MDIO bus name

From: Florian Fainelli <florian@...nwrt.org>
Date: Mon,  2 Jan 2012 10:50:00 +0100

> +	snprintf(lp->mii_bus->id, MII_BUS_ID_SIZE, "%s-%x",
> +					dev_name(&pdev->dev), card_idx);

Please don't be so sloppy with the formatting like this,
make the arguments on the second line get indented exactly
to the first column after the openning parenthesis on the
first line.

If you can't be bothered to get this right by hand, use
something like emacs's C-mode to do it for you when you hit
TAB.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html