| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <CAAwP0s1Uc28VbNnM=0prgzgMUF1dBBbx88D_kG7BRympSU41qA@mail.gmail.com> Date: Wed, 4 Jan 2012 00:30:23 +0100 From: Javier Martinez Canillas <martinez.javier@...il.com> To: David Miller <davem@...emloft.net> Cc: steve.glendinning@...c.com, ben@...adent.org.uk, eballetbo@...ebcn.com, netdev@...r.kernel.org Subject: Re: [PATCH 2/2] net/smsc911x: Check if PHY is in operational mode before software reset On Tue, Jan 3, 2012 at 7:46 PM, David Miller <davem@...emloft.net> wrote: > From: Javier Martinez Canillas <martinez.javier@...il.com> > Date: Mon, 2 Jan 2012 18:08:51 +0100 > >> + /* If energy is detected the PHY is already awake so is not necessary >> + * to disable the energy detect power-down mode. */ > ... >> + /* LAN9210/LAN9211/LAN9220/LAN9221 chips have an internal PHY that >> + * are initialized in a Energy Detect Power-Down mode that prevents >> + * the MAC chip to be software reseted. So we have to wakeup the PHY >> + * before */ > > Format these comments correctly: > > /* Like this. > * See? > */ > > /* Not like this. > * Ok? */ > Ok, will resend with the right style. Besides these coding style issues, does the patch looks good to you? Best regards, -- Javier Martínez Canillas (+34) 682 39 81 69 Barcelona, Spain -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists