netdev - Re: [PATCH] net: fsl: fec: fix build for mx23-only kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOMZO5BmKJP-3y_FxczuGwGfBR_3e2J9z3+gqzs-JDxOtR_PdQ@mail.gmail.com>
Date:	Tue, 3 Jan 2012 13:37:47 -0200
From:	Fabio Estevam <festevam@...il.com>
To:	Wolfram Sang <w.sang@...gutronix.de>
Cc:	netdev@...r.kernel.org,
	Fabio Estevam <fabio.estevam@...escale.com>,
	Uwe Kleine-König 
	<u.kleine-koenig@...gutronix.de>, Shawn Guo <shawn.guo@...aro.org>,
	"David S. Miller" <davem@...emloft.net>,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] net: fsl: fec: fix build for mx23-only kernel

On Tue, Jan 3, 2012 at 11:46 AM, Wolfram Sang <w.sang@...gutronix.de> wrote:
> If one only selects mx23-based boards, compile fails:
>
> drivers/net/ethernet/freescale/fec.c:410:2: error: 'FEC_HASH_TABLE_HIGH' undeclared (first use in this function)
> drivers/net/ethernet/freescale/fec.c:411:2: error: 'FEC_HASH_TABLE_LOW' undeclared (first use in this function)
>
> This is because fec.h uses CONFIG_SOC_IMX28 to determine the register
> layout of the core which makes sense since the MX23 does not have a fec.
> However, Kconfig uses the broader ARCH_MXS symbol and this way even
> makes the fec-driver default for MX23. Adapt Kconfig to use the more
> precise SOC_IMX28 as well.
>
> Signed-off-by: Wolfram Sang <w.sang@...gutronix.de>
> Cc: Fabio Estevam <fabio.estevam@...escale.com>
> Cc: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> Cc: Shawn Guo <shawn.guo@...aro.org>
> Cc: David S. Miller <davem@...emloft.net>

Acked-by: Fabio Estevam <fabio.estevam@...escale.com>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html