netdev - Re: [PATCH] bonding: fix error handling if slave is busy (v2)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20120103.124935.657537317702636488.davem@davemloft.net>
Date:	Tue, 03 Jan 2012 12:49:35 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	nicolas.2p.debian@...il.com
Cc:	shemminger@...tta.com, fubar@...ibm.com, andy@...yhouse.net,
	netdev@...r.kernel.org
Subject: Re: [PATCH] bonding: fix error handling if slave is busy (v2)

From: Nicolas de Pesloüan <nicolas.2p.debian@...il.com>
Date: Sun, 01 Jan 2012 01:09:50 +0100

> Le 01/01/2012 00:26, Stephen Hemminger a écrit :
>> If slave device already has a receive handler registered, then the
>> error unwind of bonding device enslave function is broken.
>>
>> The following will leave a pointer to freed memory in the slave
>> device list, causing a later kernel panic.
>> # modprobe dummy
>> # ip li add dummy0-1 link dummy0 type macvlan
>> # modprobe bonding
>> # echo +dummy0>/sys/class/net/bond0/bonding/slaves
>>
>> The fix is to detach the slave (which removes it from the list)
>> in the unwind path.
>>
>> Signed-off-by: Stephen Hemminger<shemminger@...tta.com>
> 
> Thanks Stephen.
> 
> Reviewed-by: Nicolas de Pesloüan <nicolas.2p.debian@...e.fr>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html