netdev - Re: [PATCH 2/2] net/smsc911x: Check if PHY is in operational mode before software reset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 03 Jan 2012 13:46:47 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	martinez.javier@...il.com
Cc:	steve.glendinning@...c.com, ben@...adent.org.uk,
	eballetbo@...ebcn.com, netdev@...r.kernel.org
Subject: Re: [PATCH 2/2] net/smsc911x: Check if PHY is in operational mode
 before software reset

From: Javier Martinez Canillas <martinez.javier@...il.com>
Date: Mon,  2 Jan 2012 18:08:51 +0100

> +	/* If energy is detected the PHY is already awake so is not necessary
> +	 * to disable the energy detect power-down mode. */
 ...
> +	/* LAN9210/LAN9211/LAN9220/LAN9221 chips have an internal PHY that
> +	 * are initialized in a Energy Detect Power-Down mode that prevents
> +	 * the MAC chip to be software reseted. So we have to wakeup the PHY
> +	 * before */

Format these comments correctly:

	/* Like this.
	 * See?
	 */

	/* Not like this.
	 * Ok? */

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html