netdev - Re: [PATCH] ipv6: Check RA for sllao when configuring optimistic ipv6 address

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120104195248.GC24324@hmsreliant.think-freely.org>
Date:	Wed, 4 Jan 2012 14:52:48 -0500
From:	Neil Horman <nhorman@...driver.com>
To:	David Miller <davem@...emloft.net>
Cc:	netdev@...r.kernel.org, yoshfuji@...ux-ipv6.org
Subject: Re: [PATCH] ipv6: Check RA for sllao when configuring optimistic
 ipv6 address

On Wed, Jan 04, 2012 at 02:43:18PM -0500, David Miller wrote:
> From: Neil Horman <nhorman@...driver.com>
> Date: Wed,  4 Jan 2012 11:47:23 -0500
> 
> > +extern void addrconf_prefix_rcv(struct net_device *dev,
> > +				u8 *opt, int len, void *sllao);
> 
> You're not going to dereference or inspect 'sllao' otherwise you'd
> give it a more appropriate type.  You just care if it was present or
> not.
> 
> So why not just make 'sllao' a "bool" and the argument passed as the
> test "X != NULL"?
> 

Honestly I was just avoiding doing the extra comparison.  I'm happy to pass it
as a test like that though if you think its cleaner.  I'll repost shortly.

Neil

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html