netdev - Re: [PATCH] ipv6: Check RA for sllao when configuring optimistic ipv6 address (v2)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20120104.155335.352434092951444020.davem@davemloft.net>
Date:	Wed, 04 Jan 2012 15:53:35 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	nhorman@...driver.com
Cc:	netdev@...r.kernel.org, yoshfuji@...ux-ipv6.org
Subject: Re: [PATCH] ipv6: Check RA for sllao when configuring optimistic
 ipv6 address (v2)

From: Neil Horman <nhorman@...driver.com>
Date: Wed,  4 Jan 2012 15:49:15 -0500

> Recently Dave noticed that a test we did in ipv6_add_addr to see if we next hop
> route for the interface we're adding an addres to was wrong (see commit
> 7ffbcecbeed91e5874e9a1cfc4c0cbb07dac3069).  for one, it never triggers, and two,
> it was completely wrong to begin with.  This test was meant to cover this
> section of RFC 4429:
> 
> 3.3 Modifications to RFC 2462 Stateless Address Autoconfiguration
> 
>    * (modifies section 5.5) A host MAY choose to configure a new address
>         as an Optimistic Address.  A host that does not know the SLLAO
>         of its router SHOULD NOT configure a new address as Optimistic.
>         A router SHOULD NOT configure an Optimistic Address.
> 
> This patch should bring us into proper compliance with the above clause.  Since
> we only add a SLAAC address after we've received a RA which may or may not
> contain a source link layer address option, we can pass a pointer to that option
> to addrconf_prefix_rcv (which may be null if the option is not present), and
> only set the optimistic flag if the option was found in the RA.
> 
> Change notes:
> (v2) modified the new parameter to addrconf_prefix_rcv to be a bool rather than
> a pointer to make its use more clear as per request from davem.
> 
> Signed-off-by: Neil Horman <nhorman@...driver.com>

Applied, thanks Neil.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html