netdev - Re: [PATCH v6 09/11] virtio: net: Add freeze, restore handlers to support S4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <87ty4cchbo.fsf@rustcorp.com.au>
Date:	Wed, 04 Jan 2012 13:19:47 +1030
From:	Rusty Russell <rusty@...tcorp.com.au>
To:	Amit Shah <amit.shah@...hat.com>,
	"Michael S. Tsirkin" <mst@...hat.com>
Cc:	Virtualization List <virtualization@...ts.linux-foundation.org>,
	linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org,
	netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH v6 09/11] virtio: net: Add freeze, restore handlers to support S4

On Tue, 3 Jan 2012 22:37:48 +0530, Amit Shah <amit.shah@...hat.com> wrote:
> On (Sun) 01 Jan 2012 [13:47:27], Michael S. Tsirkin wrote:
> > On Fri, Dec 30, 2011 at 03:08:19PM +0530, Amit Shah wrote:
> > > > 
> > > > > +	if (!try_fill_recv(vi, GFP_KERNEL))
> > > > > +		schedule_delayed_work(&vi->refill, 0);
> > > > 
> > > > This needs to be switched to non reentrant wq too?
> > > 
> > > Subsequent invocations could create problems?  Note that this will be
> > > the first item to be queued in the workqueue for the refill work.
> > > 
> > > 		Amit
> > 
> > See recent patches on net-next.
> > We switched other calls to a non reentrant wq so I think same
> > reasoning applies there.
> 
> There's a patch ordering issue; so this series should land after the
> -net series is merged.
> 
> Rusty, do you want me to re-spin this patch on top of yours, or is
> that something that you'll handle?

Indeed, this can't go via -net, since it needs the virtio-pci patches
which change power management.

I've changed that one line, and will post those patches for DaveM's ack.

Thanks,
Rusty.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html