netdev - Re: pull request: wireless 2012-01-04

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4F048F26.5000804@lwfinger.net>
Date:	Wed, 04 Jan 2012 11:40:54 -0600
From:	Larry Finger <Larry.Finger@...inger.net>
To:	"John W. Linville" <linville@...driver.com>
CC:	davem@...emloft.net, linux-wireless@...r.kernel.org,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: pull request: wireless 2012-01-04

On 01/04/2012 10:31 AM, John W. Linville wrote:
> On Wed, Jan 04, 2012 at 10:58:16AM -0500, John W. Linville wrote:
>
>> I was hesitant to include the rtlwifi fix, but settled on inclusion
>> because it was a product of a recent ginormous thread about the
>> intersection of firmware loading and suspend/resume.  Plus it fixes
>> a bug report in the Red Hat Bugzilla. :-) If you don't think it is
>> worthy, let me know and I'll drop it from this release.
>
> It looks like this could generate a build warning...
>
> 	http://marc.info/?l=linux-wireless&m=132569396407866&w=2
>
> I'm getting cold feet on this one.  I withdraw this pull request --
> new one to follow soon!

John,

I will resubmit this patch with a fix.

I now realize that my fix has a different problem in that the firmware might not 
be preserved under certain scenarios if there were two instances of the device 
sharing the driver. These are corner cases, but I would like to fix that as well.

Is there any way for a driver to know that it is being initialized for a second 
device?

Thanks,

Larry
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html