netdev - Re: [PATCH] r8169: Enable suspend when device is idle from boot.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOesGMip7hRsGmRuQ7PmDReKp08awsrq_0R+0BouLEisyMpMGg@mail.gmail.com>
Date:	Wed, 4 Jan 2012 10:01:44 -0800
From:	Olof Johansson <olof@...om.net>
To:	Francois Romieu <romieu@...zoreil.com>
Cc:	tbroch@...omium.org, David Miller <davem@...emloft.net>,
	nic_swsd@...ltek.com, netdev@...r.kernel.org,
	Hayes Wang <hayeswang@...ltek.com>
Subject: Re: [PATCH] r8169: Enable suspend when device is idle from boot.

On Tue, Jan 3, 2012 at 3:30 PM, Francois Romieu <romieu@...zoreil.com> wrote:
> Francois Romieu <romieu@...zoreil.com> :
> [...]
>> The description of the patch implies that the initial power management
>> state is not right. I would be more inclined to set it correctly when
>> the device goes up instead of checking repeatedly for a loss of sync
>> through rtl8169_runtime_idle. Todd, any comment ?
>
> ... which could be as simple as (completely untested) :

That change is just to the code path of open(), which means that for
the power savings to kick in, you have to bring the interface up. The
point of the original patch is to check even if the interface has
never been touched.

Perhaps call check_link_status at the end if init_one instead to
activate pm then?


-Olof
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html