netdev - Re: [PATCH v2] drivers: net: Fix dependency for EEPROM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 5 Jan 2012 17:02:46 -0200
From:	Fabio Estevam <festevam@...il.com>
To:	David Miller <davem@...emloft.net>
Cc:	Larry.Finger@...inger.net, netdev@...r.kernel.org,
	linux-wireless@...r.kernel.org, gwingerde@...il.com,
	linville@...driver.com, fabio.estevam@...escale.com,
	bhutchings@...arflare.com
Subject: Re: [PATCH v2] drivers: net: Fix dependency for EEPROM_93CX6

On Thu, Jan 5, 2012 at 4:06 PM, Fabio Estevam <festevam@...il.com> wrote:

> I have tried selecting MISC_DEVICES in the Kconfig's, but the warning remains.
>
> I agree with Ben's comment: "That seems like a bug, since MISC_DEVICES
> doesn't by itself select any
> code.  (It's also not a meaningful category and maybe ought not to be an
> option at all.)"

What about the aproach below?

drivers/misc/Kconfig |   12 ++----------
 1 files changed, 2 insertions(+), 10 deletions(-)

diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig
index 6a1a092..9c7a474 100644
--- a/drivers/misc/Kconfig
+++ b/drivers/misc/Kconfig
@@ -10,15 +10,8 @@ config SENSORS_LIS3LV02D
 	select INPUT_POLLDEV
 	default n

-menuconfig MISC_DEVICES
-	bool "Misc devices"
-	---help---
-	  Say Y here to get to see options for device drivers from various
-	  different categories. This option alone does not add any kernel code.
-
-	  If you say N, all options in this submenu will be skipped and disabled.
+menu "Misc devices"

-if MISC_DEVICES

 config AD525X_DPOT
 	tristate "Analog Devices Digital Potentiometers"
@@ -516,5 +509,4 @@ source "drivers/misc/ti-st/Kconfig"
 source "drivers/misc/lis3lv02d/Kconfig"
 source "drivers/misc/carma/Kconfig"
 source "drivers/misc/altera-stapl/Kconfig"
-
-endif # MISC_DEVICES
+endmenu
-- 

This would remove the unneeded dependency of MISC_DEVICES.

I know I need to take extra care not to break other things, but just
would like to get a feedback if this approach goes into the right
direction.

Thanks,

Fabio Estevam
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html