netdev - Re: [PATCH 5/6] net: add paged frag destructor support to kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20120105.141522.1303730212186060591.davem@davemloft.net>
Date:	Thu, 05 Jan 2012 14:15:22 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	ian.campbell@...rix.com
Cc:	netdev@...r.kernel.org, eric.dumazet@...il.com,
	kuznet@....inr.ac.ru, pekkas@...core.fi, jmorris@...ei.org,
	yoshfuji@...ux-ipv6.org, kaber@...sh.net,
	Trond.Myklebust@...app.com, gregkh@...e.de,
	drbd-user@...ts.linbit.com, devel@...verdev.osuosl.org,
	cluster-devel@...hat.com, ocfs2-devel@....oracle.com,
	ceph-devel@...r.kernel.org, rds-devel@....oracle.com,
	linux-nfs@...r.kernel.org
Subject: Re: [PATCH 5/6] net: add paged frag destructor support to
 kernel_sendpage.

From: Ian Campbell <ian.campbell@...rix.com>
Date: Thu, 5 Jan 2012 17:13:43 +0000

> -static ssize_t do_tcp_sendpages(struct sock *sk, struct page **pages, int poffset,
> +static ssize_t do_tcp_sendpages(struct sock *sk,
> +				struct page **pages,
> +				struct skb_frag_destructor **destructors,
> +				int poffset,
>  			 size_t psize, int flags)
>  {
>  	struct tcp_sock *tp = tcp_sk(sk);

An array of destructors is madness, and the one call site that specifies this
passes an address of a single entry.

This also would never even have to occur if you put the destructor inside of
struct page instead.

Finally, except for the skb_shared_info() layout optimization in patch #1 which
I alreayd applied, this stuff is not baked enough for the 3.3 merge window.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html