netdev - Re: [PATCH] xen-netback: make ops structs const

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1325753087.25206.336.camel@zakaz.uk.xensource.com>
Date:	Thu, 5 Jan 2012 08:44:46 +0000
From:	Ian Campbell <Ian.Campbell@...rix.com>
To:	Stephen Hemminger <shemminger@...tta.com>
CC:	"xen-devel@...ts.xensource.com" <xen-devel@...ts.xensource.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH] xen-netback: make ops structs const

On Wed, 2012-01-04 at 21:56 +0000, Stephen Hemminger wrote:
> All tables of function pointers should be const to make hacks
> more difficult. Compile tested only.

I also eyeballed for any writes to these structs and couldn't find one.

> Signed-off-by: Stephen Hemminger <shemminger@...tta.com>

Acked-by: Ian Campbell <ian.campbell@...rix.com>

> 
> ---
> Patch against net-next
> 
> --- a/drivers/net/xen-netback/interface.c	2011-12-07 10:54:19.232282492 -0800
> +++ b/drivers/net/xen-netback/interface.c	2012-01-04 13:16:04.414052721 -0800
> @@ -223,7 +223,7 @@ static void xenvif_get_strings(struct ne
>  	}
>  }
>  
> -static struct ethtool_ops xenvif_ethtool_ops = {
> +static const struct ethtool_ops xenvif_ethtool_ops = {
>  	.get_link	= ethtool_op_get_link,
>  
>  	.get_sset_count = xenvif_get_sset_count,
> @@ -231,7 +231,7 @@ static struct ethtool_ops xenvif_ethtool
>  	.get_strings = xenvif_get_strings,
>  };
>  
> -static struct net_device_ops xenvif_netdev_ops = {
> +static const struct net_device_ops xenvif_netdev_ops = {
>  	.ndo_start_xmit	= xenvif_start_xmit,
>  	.ndo_get_stats	= xenvif_get_stats,
>  	.ndo_open	= xenvif_open,


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html