netdev - Re: [PATCH 3/6] net: add support for per-paged-fragment destructors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1325839831.25206.423.camel@zakaz.uk.xensource.com>
Date:	Fri, 6 Jan 2012 08:50:31 +0000
From:	Ian Campbell <Ian.Campbell@...rix.com>
To:	Michał Mirosław <mirq-linux@...e.qmqm.pl>
CC:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	David Miller <davem@...emloft.net>,
	Eric Dumazet <eric.dumazet@...il.com>
Subject: Re: [PATCH 3/6] net: add support for per-paged-fragment destructors

On Fri, 2012-01-06 at 01:15 +0000, Michał Mirosław wrote:
> On Thu, Jan 05, 2012 at 05:13:41PM +0000, Ian Campbell wrote:
> > Entities which care about the complete lifecycle of pages which they inject
> > into the network stack via an skb paged fragment can choose to set this
> > destructor in order to receive a callback when the stack is really finished
> > with a page (including all clones, retransmits, pull-ups etc etc).
> [...]
> > --- a/include/linux/skbuff.h
> > +++ b/include/linux/skbuff.h
> > @@ -143,9 +143,16 @@ struct sk_buff;
> >  
> >  typedef struct skb_frag_struct skb_frag_t;
> >  
> > +struct skb_frag_destructor {
> > +	atomic_t ref;
> > +	int (*destroy)(void *data);
> > +	void *data;
> > +};
> > +
> [...]
> 
> What happened to removal of 'data' field from this structure?

I did that in my branch where I also moved the *page into there (to try
and shrink the frag size) and forgot to rescue it when I switched back.
I'll make the change again for next time.

Thanks for the reminder.

Ian.



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html