netdev - Re: [PATCH] bond_alb: don't disable softirq under bond_alb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20120107.101450.2214394343146869929.davem@davemloft.net>
Date:	Sat, 07 Jan 2012 10:14:50 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	fubar@...ibm.com
Cc:	maxim.uvarov@...cle.com, netdev@...r.kernel.org,
	andy@...yhouse.net, amwang@...hat.com
Subject: Re: [PATCH] bond_alb: don't disable softirq under bond_alb_xmit

From: Jay Vosburgh <fubar@...ibm.com>
Date: Fri, 06 Jan 2012 13:33:25 -0800

> Maxim Uvarov <maxim.uvarov@...cle.com> wrote:
> 
>>No need to lock soft irqs under bond_alb_xmit()
>>which already has softirq disabled.
> 
> 	In commit:
> 
> commit 6603a6f25e4bca922a7dfbf0bf03072d98850176
> Author: Jay Vosburgh <fubar@...ibm.com>
> Date:   Wed Oct 17 17:37:50 2007 -0700
> 
>     bonding: Convert more locks to _bh, acquire rtnl, for new locking
>     
>         Convert more lock acquisitions to _bh flavor to avoid deadlock
>     with workqueue activity and add acquisition of RTNL in appropriate places.
>     Affects ALB mode, as well as core bonding functions and sysfs.
>     
>     Signed-off-by: Andy Gospodarek <andy@...yhouse.net>
>     Signed-off-by: Jay Vosburgh <fubar@...ibm.com>
>     Signed-off-by: Jeff Garzik <jeff@...zik.org>
> 
> 	the _lock_tx_hashtbl was upgraded from regular to _bh to prevent
> deadlocks.  I don't recall right offhand what deadlock this prevented,
> but are we sure there are no possible issues with converting this lock
> back to a non-_bh acquisition?

Maxim's patch is not changing the BH'ness of the list.


He's just avoiding a BH disable which is unnecessary because BH is
already disabled in the effected code path(s).

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html