netdev - Re: [RFC] pktgen: set correct max and min in pktgen_setup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20120107.122547.2205195083782290771.davem@davemloft.net>
Date:	Sat, 07 Jan 2012 12:25:47 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	jesse.brandeburg@...el.com
Cc:	dan.carpenter@...cle.com, netdev@...r.kernel.org
Subject: Re: [RFC] pktgen: set correct max and min in pktgen_setup_inject()

From: Jesse Brandeburg <jesse.brandeburg@...el.com>
Date: Fri, 6 Jan 2012 09:29:12 -0800

> On Fri, 6 Jan 2012 05:13:47 -0800
> Dan Carpenter <dan.carpenter@...cle.com> wrote:
> 
>> In 882716604ec "pktgen: fix multiple queue warning" we added special
>> logic to handle the case where ntxq is zero.  It's not clear to me that
>> ntxq can actually be zero.  But if it were then we would set
>> ->queue_map_min and ->queue_map_max to USHRT_MAX when probably we want
>> to set them to zero?
> 
> seems fine to me, esp since -1 seems like a bad value there.

Looks good to me too, applied, thanks everyone.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html