netdev - RE: [PATCH] gianfar: Fix invalid TX frames returned on error queue when time stamping.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1326103126.2407.1.camel@edumazet-HP-Compaq-6005-Pro-SFF-PC>
Date:	Mon, 09 Jan 2012 10:58:46 +0100
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Manfred Rudigier <manfred.rudigier@...cron.at>
Cc:	David Miller <davem@...emloft.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"afleming@...escale.com" <afleming@...escale.com>,
	"avorontsov@...sta.com" <avorontsov@...sta.com>
Subject: RE: [PATCH] gianfar: Fix invalid TX frames returned on error queue
 when time stamping.

Le lundi 09 janvier 2012 à 10:36 +0100, Manfred Rudigier a écrit :

> I have tried your suggested steal sequence, but it crashed. 
> I see that there is also a destructor - when I use the skb_orphan function (which calls the destructor) like this it works:
> 
> 	skb_new->sk = skb->sk;
> 	skb_orphan(skb);
> 	kfree_skb(skb);
> 
> Is this the correct solution?

I dont think so.

destructor and sk are coupled, you cant steal one and let the other
untouched.



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html