lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 09 Jan 2012 11:15:27 +0100 From: Florian Fainelli <florian@...nwrt.org> To: David Miller <davem@...emloft.net> CC: cesarb@...arb.net, netdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] r6040: fix typo in use of MCR0 register bits On 01/07/12 21:09, David Miller wrote: > From: Cesar Eduardo Barros<cesarb@...arb.net> > Date: Sat, 7 Jan 2012 13:13:17 -0200 > >> Commit 4e16d6ebd65b4f2c4e3f780b4c5704beef64019c (r6040: define more MCR0 >> register bits) added #define values for MCR0 register bits and converted >> uses of hardcoded magic values to uses of these defines. >> >> However, one of the conversions looks suspicious: >> >> #define MCR0 0x00 /* Control register 0 */ >> +#define MCR0_RCVEN 0x0002 /* Receive enable */ >> +#define MCR0_XMTEN 0x1000 /* Transmission enable */ >> >> /* Init RDC private data */ >> - lp->mcr0 = 0x1002; >> + lp->mcr0 = MCR0_XMTEN | MCR0; >> >> I believe what was meant here was MCR0_XMTEN | MCR0_RCVEN, which makes >> sense and matches the original values. >> >> Signed-off-by: Cesar Eduardo Barros<cesarb@...arb.net> > Good catch, applied, thanks a lot. Indeed, thanks Cesar. -- Florian -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists