netdev - Re: [PATCH] gianfar: Fix invalid TX frames returned on error queue when time stamping.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120109125034.GC4404@cherladcori01>
Date:	Mon, 9 Jan 2012 13:50:34 +0100
From:	Richard Cochran <richardcochran@...il.com>
To:	Manfred Rudigier <manfred.rudigier@...cron.at>
Cc:	Eric Dumazet <eric.dumazet@...il.com>,
	David Miller <davem@...emloft.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"afleming@...escale.com" <afleming@...escale.com>,
	"avorontsov@...sta.com" <avorontsov@...sta.com>
Subject: Re: [PATCH] gianfar: Fix invalid TX frames returned on error queue
 when time stamping.

On Mon, Jan 09, 2012 at 01:41:08PM +0100, Richard Cochran wrote:
> 
> 	if (((skb->ip_summed == CHECKSUM_PARTIAL) ||
>       	   		vlan_tx_tag_present(skb) ||
> 			unlikely(do_tstamp)) &&
> 			(skb_headroom(skb) < GMAC_FCB_LEN)) {
> 		struct sk_buff *skb_new;
> 		...
> 	}
> 
> IOW, there was always at least GMAC_FCB_LEN bytes in skb_headroom.

And now, you are asking for more space.

Richard
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html