netdev - Re: [PATCH 2/2] asix: fix setting custom MAC address on Asix 88178 devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20120110.150051.1786115333097978498.davem@davemloft.net>
Date:	Tue, 10 Jan 2012 15:00:51 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	jussi.kivilinna@...et.fi
Cc:	netdev@...r.kernel.org, grundler@...omium.org, allan@...x.com.tw
Subject: Re: [PATCH 2/2] asix: fix setting custom MAC address on Asix 88178
 devices

From: Jussi Kivilinna <jussi.kivilinna@...et.fi>
Date: Tue, 10 Jan 2012 18:40:23 +0200

> (Note: only compile tested, I don't have 88178 device to confirm that this
> patch works. Please, test.)
> 
> ---
> 
> In kernel v3.2 initialization sequence for Asix 88178 devices was changed so
> that hardware is reseted on every time interface is brought up (ifconfig up),
> instead just at USB probe time. This causes problem with setting custom MAC
> address to device as ax88178_reset causes reload of MAC address from EEPROM.
> 
> This patch fixes the issue by rewriting MAC address at end of ax88178_reset.
> 
> Signed-off-by: Jussi Kivilinna <jussi.kivilinna@...et.fi>
> Cc: Grant Grundler <grundler@...omium.org>
> Cc: Allan Chou <allan@...x.com.tw>
> Cc: stable <stable@...r.kernel.org>
> ---

Please do not format your commit messages like this, everything after
that first "---" will be stripped away.  So in this case if I applied
this email into GIT as-is we'd lose the actual commit message and
only have your "(Note: " thing.

I fixed this up and applied it with Grant's ACK.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html