netdev - RE: [PATCH v2] gianfar: Fix invalid TX frames returned on error queue when time stamping.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 10 Jan 2012 10:05:15 +0100
From:	Manfred Rudigier <manfred.rudigier@...cron.at>
To:	Eric Dumazet <eric.dumazet@...il.com>
CC:	"davem@...emloft.net" <davem@...emloft.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"afleming@...escale.com" <afleming@...escale.com>,
	"avorontsov@...sta.com" <avorontsov@...sta.com>,
	"richardcochran@...il.com" <richardcochran@...il.com>
Subject: RE: [PATCH v2] gianfar: Fix invalid TX frames returned on error
 queue when time stamping.

From: netdev-owner@...r.kernel.org [mailto:netdev-
owner@...r.kernel.org] On Behalf Of Eric Dumazet
Sent: Monday, January 09, 2012 16:12

>> +
>> +		/* Hold sock reference for processing TX time stamps */
>> +		if (unlikely(do_tstamp)) {
>> +			struct sock *sk = skb->sk;
>
>Not clear to me why sk_refcnt could be 0 here

Well, I have tried to make a similar solution as outlined in commit da92b194cc36b5dc1fbd85206aeeffd80bee0c39.

>I would rather do something like :
>
>diff --git a/drivers/net/ethernet/freescale/gianfar.c
>b/drivers/net/ethernet/freescale/gianfar.c
>index e01cdaa..8e00461 100644
>--- a/drivers/net/ethernet/freescale/gianfar.c
>+++ b/drivers/net/ethernet/freescale/gianfar.c
>@@ -2086,6 +2086,8 @@ static int gfar_start_xmit(struct sk_buff *skb, struct
>net_device *dev)
> 			kfree_skb(skb);
> 			return NETDEV_TX_OK;
> 		}
>+		swap(skb_new->sk, skb->sk);
>+		swap(skb_new->destructor, skb->destructor);
> 		kfree_skb(skb);
> 		skb = skb_new;
> 	}

I guess this should also work, so I will come up with a new version.