netdev - RE: [PATCH net-next v2 2/4] can: cc770: add legacy ISA bus driver for the CC770 and AN82527

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AE90C24D6B3A694183C094C60CF0A2F6D8AF39@saturn3.aculab.com>
Date:	Tue, 10 Jan 2012 10:00:49 -0000
From:	"David Laight" <David.Laight@...LAB.COM>
To:	<info@...ax.com>, "Wolfgang Grandegger" <wg@...ndegger.com>,
	"Oliver Hartkopp" <socketcan@...tkopp.net>, <henrik@...conx.com>
Cc:	<netdev@...r.kernel.org>, <linux-can@...r.kernel.org>,
	<socketcan-users@...ts.berlios.de>, "IreneV" <boir1@...dex.ru>,
	"Stanislav Yelenskiy" <stanislavelensky@...oo.com>, <oe@...t.de>,
	<henrik@...us-sw.com>
Subject: RE: [PATCH net-next v2 2/4] can: cc770: add legacy ISA bus driver for the CC770 and AN82527

 
> cc770_isa_port_write_reg_indirect(const struct cc770_priv *priv,
>   						int reg, u8 val)
>   {
>   	unsigned long base = (unsigned long)priv->reg_base;
> +	unsigned long flags;
> 
> +	spin_lock_irqsave( &outb_lock, flags);
>   	outb(reg, base);
>   	outb(val, base + 1);
> +	spin_unlock_irqrestore( &outb_lock, flags);	

Is there a 'read_reg_indirect' function??
If so it also needs to use the same mutex.
I'd double check all references to the 'reg_base' field.

	David


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html