netdev - Re: [PATCH] stmmac: Add missing LF to pr_info() in stmmac

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4F0C5019.9090103@st.com>
Date:	Tue, 10 Jan 2012 15:50:01 +0100
From:	Giuseppe CAVALLARO <peppe.cavallaro@...com>
To:	Stefan Roese <sr@...x.de>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] stmmac: Add missing LF to pr_info() in stmmac_main.c

On 1/10/2012 12:47 PM, Stefan Roese wrote:
> Otherwise the output looks like this:
> 
> ...
> STMMAC - user ID: 0x10, Synopsys ID: 0x32
>  No HW DMA feature register supported
>  Normal descriptors
>  Remote wake-up capable
>  Checksum Offload Engine supported
>  No MAC Management Counters availableIP-Config: Complete:
>      device=eth0, addr=192.168.20.42, mask=255.255.0.0, gw=192.168.1.254,
> ...
> 
> Signed-off-by: Stefan Roese <sr@...x.de>
> Cc: Giuseppe Cavallaro <peppe.cavallaro@...com>

Acked-by: Giuseppe Cavallaro <peppe.cavallaro@...com>

> ---
>  drivers/net/ethernet/stmicro/stmmac/stmmac_main.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> index 3738b47..ee85a14 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> @@ -772,7 +772,7 @@ static void stmmac_mmc_setup(struct stmmac_priv *priv)
>  		dwmac_mmc_ctrl(priv->ioaddr, mode);
>  		memset(&priv->mmc, 0, sizeof(struct stmmac_counters));
>  	} else
> -		pr_info(" No MAC Management Counters available");
> +		pr_info(" No MAC Management Counters available\n");
>  }
>  
>  static u32 stmmac_get_synopsys_id(struct stmmac_priv *priv)

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html