netdev - Re: [PATCHv2] bond_alb: don't disable softirq under bond_alb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 10 Jan 2012 12:52:59 -0500
From:	Andy Gospodarek <gospo@...hat.com>
To:	Maxim Uvarov <maxim.uvarov@...cle.com>
Cc:	Andy Gospodarek <gospo@...hat.com>, netdev@...r.kernel.org,
	fubar@...ibm.com, andy@...yhouse.net, davem@...emloft.net,
	Cong Wang <amwang@...hat.com>
Subject: Re: [PATCHv2] bond_alb: don't disable softirq under bond_alb_xmit

On Mon, Jan 09, 2012 at 07:09:32PM -0800, Maxim Uvarov wrote:
> On 01/09/2012 02:20 PM, Andy Gospodarek wrote:
> >On Mon, Jan 09, 2012 at 02:01:37PM -0800, Maxim Uvarov wrote:
> >>No need to lock soft irqs under bond_alb_xmit()
> >>which already has softirq disabled.
> >>
> >>Changes:
> >>1. add non-bh/bh version to tlb_clear_slave()
> >>
> >>2. represent BH and non BH hash table locks
> >>_lock_rx_hashtbl_bh/_unlock_rx_hashtbl_bh
> >>_lock_rx_hashtbl/_unlock_rx_hashtbl
> >>_lock_tx_hashtbl_bh/_unlock_tx_hashtbl_bh
> >>_lock_tx_hashtbl/_unlock_tx_hashtbl
> >>
> >>Signed-off-by: Maxim Uvarov<maxim.uvarov@...cle.com>
> >>Signed-off-by: Cong Wang<amwang@...hat.com>
> >>---
> >>  drivers/net/bonding/bond_alb.c |  112 +++++++++++++++++++++++++++-------------
> >>  1 files changed, 76 insertions(+), 36 deletions(-)
> >>
> >
> >Did you test this with CONFIG_DEBUG_LOCKDEP=y at all?
> >
> 
> Just did some simple tests on bond0 with LOCKDEP. Do not see any warnings.
> 

OK, I will test it today and let you know how it looks.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html