netdev - Re: [PATCH 02/21] bfin_mac: use an unique MDIO bus name.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 11 Jan 2012 22:47:31 +0800
From:	Bob Liu <lliubbo@...il.com>
To:	Florian Fainelli <florian@...nwrt.org>
Cc:	netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>,
	Jeff Kirsher <jeffrey.t.kirsher@...el.com>,
	Jiri Pirko <jpirko@...hat.com>, Bob Liu <bob.liu@...log.com>,
	uclinux-dist-devel@...ckfin.uclinux.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 02/21] bfin_mac: use an unique MDIO bus name.

On Tue, Jan 10, 2012 at 5:59 PM, Florian Fainelli <florian@...nwrt.org> wrote:
> Signed-off-by: Florian Fainelli <florian@...nwrt.org>
> ---
>  drivers/net/ethernet/adi/bfin_mac.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/ethernet/adi/bfin_mac.c b/drivers/net/ethernet/adi/bfin_mac.c
> index b6d69c9..d812a10 100644
> --- a/drivers/net/ethernet/adi/bfin_mac.c
> +++ b/drivers/net/ethernet/adi/bfin_mac.c
> @@ -1670,7 +1670,8 @@ static int __devinit bfin_mii_bus_probe(struct platform_device *pdev)
>        miibus->name = "bfin_mii_bus";
>        miibus->phy_mask = mii_bus_pd->phy_mask;
>
> -       snprintf(miibus->id, MII_BUS_ID_SIZE, "0");
> +       snprintf(miibus->id, MII_BUS_ID_SIZE, "%s-%x",
> +               pdev->name, pdev->id);
>        miibus->irq = kmalloc(sizeof(int)*PHY_MAX_ADDR, GFP_KERNEL);
>        if (!miibus->irq)
>                goto out_err_irq_alloc;
> --
> 1.7.5.4

Looks fine for me.  Thanks.

Acked-by: Bob Liu <lliubbo@...il.com>

-- 
Regards,
--Bob
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html