netdev - Re: [PATCH] dp83640: Fix NOHZ local_softirq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120111190300.GA14376@netboy.at.omicron.at>
Date:	Wed, 11 Jan 2012 20:03:00 +0100
From:	Richard Cochran <richardcochran@...il.com>
To:	Manfred Rudigier <manfred.rudigier@...cron.at>
Cc:	davem@...emloft.net, netdev@...r.kernel.org
Subject: Re: [PATCH] dp83640: Fix NOHZ local_softirq_pending 08 warning

On Tue, Jan 10, 2012 at 10:52:15AM +0100, Manfred Rudigier wrote:
> Similar problem as in 481a8199142c050b72bff8a1956a49fd0a75bbe0. This fix
> replaces netif_rx() with netif_rx_ni() which has to be used from
> process/softirq context.

Thanks for spotting this. Can you post this once again with a Cc tag
for the stable branch, too?

Thanks,
Richard

> 
> Signed-off-by: Manfred Rudigier <manfred.rudigier@...cron.at>
> ---
>  drivers/net/phy/dp83640.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/net/phy/dp83640.c b/drivers/net/phy/dp83640.c
> index 9663e0b..ba3c591 100644
> --- a/drivers/net/phy/dp83640.c
> +++ b/drivers/net/phy/dp83640.c
> @@ -1159,7 +1159,7 @@ static void rx_timestamp_work(struct work_struct *work)
>  			}
>  		}
>  		spin_unlock_irqrestore(&dp83640->rx_lock, flags);
> -		netif_rx(skb);
> +		netif_rx_ni(skb);
>  	}
>  
>  	/* Clear out expired time stamps. */
> -- 
> 1.7.0.4
> 
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html