netdev - Re: [PATCH 0/2] inet_diag: Fix old/new inet_diag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20120111.125813.546007433493549448.davem@davemloft.net>
Date:	Wed, 11 Jan 2012 12:58:13 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	xemul@...allels.com
Cc:	shemminger@...ux-foundation.org, netdev@...r.kernel.org
Subject: Re: [PATCH 0/2] inet_diag: Fix old/new inet_diag_req-s structures

From: Pavel Emelyanov <xemul@...allels.com>
Date: Wed, 11 Jan 2012 12:35:32 +0400

> The recent changes to inet_diag broke the compilation of tools using kernel headers.
> 
> Fix this by doing two sequential renames:
> 
>  inet_diag_req -> inet_diag_req_v2
>  inet_diag_req_compat -> inet_diag_req
> 
> After this the changes in the user-space visible part of the inet_diag.h are
> * add the inet_diag_req_v2
> * extend the INET_DIAG_ extensions list
> 
> The set applies to current net tree.

Both applied, thanks.

> David, Stephen, I'm a little bit confused with the situation with this header. Can
> you please comment on the (quite ancient) commit 73c1f4a0 ([TCPDIAG]: Just rename 
> everything to inet_diag) from acme@? This commit did the similar thing with inet_diag
> header -- flushed away the old struct and introduced a new one keeping just the binary
> compatibility. Why was the breakage of tools caused by this commit considered as 
> acceptable?

Sigh... we simply didn't notice it back then, and that's the end of
it.  Can you please stop bringing up this point now?  Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html