netdev - Re: brcm80211 breakage..

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 11 Jan 2012 21:30:05 -0800
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Larry Finger <Larry.Finger@...inger.net>
Cc:	Arend van Spriel <arend@...adcom.com>,
	"John W. Linville" <linville@...driver.com>,
	Network Development <netdev@...r.kernel.org>,
	"Franky (Zhenhui) Lin" <frankyl@...adcom.com>,
	Rafał Miłecki <zajec5@...il.com>
Subject: Re: brcm80211 breakage..

On Wed, Jan 11, 2012 at 9:20 PM, Linus Torvalds
<torvalds@...ux-foundation.org> wrote:
>
> Maybe your BIOS firmware sets things up, and the Apple Macbook Air
> doesn't? And the driver used to initialize things sufficiently, and
> the changes have broken that?

The code in v3.2 also used to support srom rev < 4, the new code
doesn't seem to do that.

Looking at the older initvars_srom_pci() (now "srom_var_init()") the
old code started out reading just SROM_WORDS, and then reading more
only if it found the srom4 signature. The new code always reads
SROM4_WORDS.

I dunno. But it looks to me like the new driver has dropped some logic
that used to exist in that driver. I don't know if it was ever used,
though, nor do I know if it's relevant. But if tat "dropped some
logic" is more widespread, it might well also cover some
initialization code.

                        Linus
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html