netdev - Re: about tx_queue_len for phonet driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1326365873.2950.6.camel@edumazet-HP-Compaq-6005-Pro-SFF-PC>
Date:	Thu, 12 Jan 2012 11:57:53 +0100
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Hemant-vilas RAMDASI <hemant.ramdasi@...ricsson.com>
Cc:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	Rémi Denis-Courmont 
	<remi.denis-courmont@...ia.com>
Subject: Re: about tx_queue_len for phonet driver

Le jeudi 12 janvier 2012 à 11:45 +0100, Hemant-vilas RAMDASI a écrit :
> Hi,
> 
> Can anyone guide me about when should a network driver set
> tx_queue_len to 0?
> We are facing a network congestion issue with phonet packets where one
> of the control message packet is dropped because of congestion. In our
> phonet network driver the tx_queue_len is set to 3 (taken from
> usb-phonet mostly). If phonet cannot handle packet-drop (for pipe
> messages), then should network driver always set tx_queue_len as 0?

0 is usually used by virtual devices, since real device has a queue.

In your case, I would rather increase a bit the tx_queue_len

I noticed in the past 3 is the default for ppp, and we can indeed have
drops because 3 is too small for current usages.



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html