netdev - Re: [ethtool] ethtool: Correct register dump offsets for Intel 82575 chipsets.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1326373862.2709.63.camel@jtkirshe-mobl>
Date:	Thu, 12 Jan 2012 05:11:02 -0800
From:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
To:	Ben Hutchings <bhutchings@...arflare.com>
Cc:	"Vick, Matthew" <matthew.vick@...el.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"gospo@...hat.com" <gospo@...hat.com>,
	"sassmann@...hat.com" <sassmann@...hat.com>
Subject: Re: [ethtool] ethtool: Correct register dump offsets for Intel
 82575 chipsets.

On Fri, 2011-12-23 at 02:32 -0800, Kirsher, Jeffrey T wrote:
> From: Matthew Vick <matthew.vick@...el.com>
> 
> When support was added to dump the registers on 82575 chipset devices,
> six register offsets (receive/transmit desc length, head, and tail)
> were incorrectly mapped. This patch remaps the offsets to the correct
> registers.
> 
> Signed-off-by: Matthew Vick <matthew.vick@...el.com>
> Tested-by: Aaron Brown <aaron.f.brown@...el.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
> ---
>  igb.c |   12 ++++++------
>  1 files changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/igb.c b/igb.c
> index ec35d36..e0ccef9 100644
> --- a/igb.c
> +++ b/igb.c
> @@ -200,13 +200,13 @@ igb_dump_regs(struct ethtool_drvinfo *info, struct ethtool_regs *regs)
>         /* Receive descriptor registers */
>         fprintf(stdout,
>                 "0x02808: RDLEN  (Receive desc length)                 0x%08X\n",
> -               regs_buff[142]);
> +               regs_buff[137]);
>         fprintf(stdout,
>                 "0x02810: RDH    (Receive desc head)                   0x%08X\n",
> -               regs_buff[146]);
> +               regs_buff[141]);
>         fprintf(stdout,
>                 "0x02818: RDT    (Receive desc tail)                   0x%08X\n",
> -               regs_buff[150]);
> +               regs_buff[145]);
> 
>         /* Transmit control register */
>         reg = regs_buff[38];
> @@ -226,13 +226,13 @@ igb_dump_regs(struct ethtool_drvinfo *info, struct ethtool_regs *regs)
>         /* Transmit descriptor registers */
>         fprintf(stdout,
>                 "0x03808: TDLEN       (Transmit desc length)           0x%08X\n",
> -               regs_buff[214]);
> +               regs_buff[219]);
>         fprintf(stdout,
>                 "0x03810: TDH         (Transmit desc head)             0x%08X\n",
> -               regs_buff[218]);
> +               regs_buff[223]);
>         fprintf(stdout,
>                 "0x03818: TDT         (Transmit desc tail)             0x%08X\n",
> -               regs_buff[222]);
> +               regs_buff[227]);
> 
> 
>         fprintf(stdout,
> --
> 1.7.7.4
> 

Ben, what is the status of this patch?

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)