netdev - Consequences of commit 16e5726269611b71c930054ffe9b858c1cea88eb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAO+b5-pGcKbTYQWdWo=kbiQ2ORbgn8GAV_cfYjGzOARmgrsUxQ@mail.gmail.com>
Date:	Thu, 12 Jan 2012 19:14:49 +0000
From:	Bart Van Assche <bvanassche@....org>
To:	netdev@...r.kernel.org
Cc:	Eric Dumazet <eric.dumazet@...il.com>,
	"David S. Miller" <davem@...emloft.net>,
	Mike Christie <michaelc@...wisc.edu>,
	Eric Paris <eparis@...hat.com>
Subject: Consequences of commit 16e5726269611b71c930054ffe9b858c1cea88eb

Hi,

If my analysis is correct commit
16e5726269611b71c930054ffe9b858c1cea88eb ("af_unix: dont send
SCM_CREDENTIALS by default") changes the value of
NETLINK_CREDS(skb)->pid from the sender pid into zero. Does that mean
that the code using that construct did work in kernel 3.1 but that it
is broken in kernel 3.2 ? Should that commit be reverted or will
someone fix the code that uses NETLINK_CREDS() ? Would changing
NETLINK_CREDS(skb)->pid into NETLINK_CB(skb).pid be sufficient ?

Thanks,

Bart.

$ git grep 'NETLINK_CREDS([a-zA-Z0-9_]*)->pid'
drivers/scsi/scsi_netlink.c:	pid = NETLINK_CREDS(skb)->pid;
kernel/audit.c:	pid  = NETLINK_CREDS(skb)->pid;
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html