netdev - Re: [PATCH] net: decrement memcg jump label when limit, not usage, is changed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20120112.122816.1727420253535508242.davem@davemloft.net>
Date:	Thu, 12 Jan 2012 12:28:16 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	glommer@...allels.com
Cc:	linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
	cgroups@...r.kernel.org
Subject: Re: [PATCH] net: decrement memcg jump label when limit, not usage,
 is changed

From: Glauber Costa <glommer@...allels.com>
Date: Thu, 12 Jan 2012 16:16:06 +0400

> The logic of the current code is that whenever we destroy
> a cgroup that had its limit set (set meaning different than
> maximum), we should decrement the jump_label counter.
> Otherwise we assume it was never incremented.
> 
> But what the code actually does is test for RES_USAGE
> instead of RES_LIMIT. Usage being different than maximum
> is likely to be true most of the time.
> 
> The effect of this is that the key must become negative,
> and since the jump_label test says:
> 
>         !!atomic_read(&key->enabled);
> 
> we'll have jump_labels still on when no one else is
> using this functionality.
> 
> Signed-off-by: Glauber Costa <glommer@...allels.com>
> CC: David S. Miller <davem@...emloft.net>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html