netdev - Re: [PATCH] vhost-net: add module alias (v2.1)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPXgP10uf-5wDxGOP8yhfUcn+18Ga+eZp-Psz_Pxe9PoJZagoA@mail.gmail.com>
Date:	Fri, 13 Jan 2012 05:19:05 +0100
From:	Kay Sievers <kay.sievers@...y.org>
To:	David Miller <davem@...emloft.net>
Cc:	shemminger@...tta.com, zwu.kernel@...il.com, device@...ana.org,
	netdev@...r.kernel.org, virtualization@...ts.linux-foundation.org,
	kvm@...r.kernel.org, mst@...hat.com
Subject: Re: [PATCH] vhost-net: add module alias (v2.1)

On Fri, Jan 13, 2012 at 05:07, David Miller <davem@...emloft.net> wrote:
> From: Stephen Hemminger <shemminger@...tta.com>
> Date: Wed, 11 Jan 2012 21:30:38 -0800
>
>> Subject: vhost-net: add module alias (v2.1)
>>
>> By adding some module aliases, programs (or users) won't have to explicitly
>> call modprobe. Vhost-net will always be available if built into the kernel.
>> It does require assigning a permanent minor number for depmod to work.
>>
>> Also:
>>   - use C99 style initialization.
>>   - add missing entry in documentation for loop-control
>>
>> Signed-off-by: Stephen Hemminger <shemminger@...tta.com>
>
> ACKs, NACKs?  What is happening here?

In general, static minors are acceptable and very useful to make
on-demand loading of kernel modules working. They should be used only
for single-instance devices though, which usually means: One single
static device name associated with a module.

That looks all fine here, and for what it's worth:
  Acked-By: Kay Sievers <kay.sievers@...y.org>

Kay
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html