netdev - Re: [PATCH] ipv6: release idev when ip6_neigh_lookup failed in icmp6_dst

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1326448121.2272.4.camel@edumazet-HP-Compaq-6005-Pro-SFF-PC>
Date:	Fri, 13 Jan 2012 10:48:41 +0100
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	roy.qing.li@...il.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] ipv6: release idev when ip6_neigh_lookup failed in
 icmp6_dst_alloc

Le vendredi 13 janvier 2012 à 16:33 +0800, roy.qing.li@...il.com a
écrit :
> From: RongQing.Li <roy.qing.li@...il.com>
> 
> release idev when ip6_neigh_lookup failed in icmp6_dst_alloc
> 
> Signed-off-by: RongQing.Li <roy.qing.li@...il.com>
> ---
>  net/ipv6/route.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/net/ipv6/route.c b/net/ipv6/route.c
> index 07361df..8c2e3ab 100644
> --- a/net/ipv6/route.c
> +++ b/net/ipv6/route.c
> @@ -1091,6 +1091,7 @@ struct dst_entry *icmp6_dst_alloc(struct net_device *dev,
>  	else {
>  		neigh = ip6_neigh_lookup(&rt->dst, &fl6->daddr);
>  		if (IS_ERR(neigh)) {
> +			in6_dev_put(idev);
>  			dst_free(&rt->dst);
>  			return ERR_CAST(neigh);
>  		}

Good catch, thanks.

Bug added in commit b43faac6906 (ipv6: If neigh lookup fails during
icmp6 dst allocation, propagate error.), 

Acked-by: Eric Dumazet <eric.dumazet@...il.com>


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html