netdev - Re: [PATCH net] dql: Fix inconsistency between file mode and attr method.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 14 Jan 2012 18:21:11 +0100
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Hiroaki SHIMODA <shimoda.hiroaki@...il.com>
Cc:	davem@...emloft.net, netdev@...r.kernel.org, therbert@...gle.com
Subject: Re: [PATCH net] dql: Fix inconsistency between file mode and attr
 method.

Le dimanche 15 janvier 2012 à 02:10 +0900, Hiroaki SHIMODA a écrit :
> There is no store() method for inflight attribute in the
> tx-<n>/byte_queue_limits sysfs directory.
> So remove S_IWUSR bit.
> 
> Signed-off-by: Hiroaki SHIMODA <shimoda.hiroaki@...il.com>
> ---
>  net/core/net-sysfs.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/net/core/net-sysfs.c b/net/core/net-sysfs.c
> index f3dbd4f..a1727cd 100644
> --- a/net/core/net-sysfs.c
> +++ b/net/core/net-sysfs.c
> @@ -929,7 +929,7 @@ static ssize_t bql_show_inflight(struct netdev_queue *queue,
>  }
>  
>  static struct netdev_queue_attribute bql_inflight_attribute =
> -	__ATTR(inflight, S_IRUGO | S_IWUSR, bql_show_inflight, NULL);
> +	__ATTR(inflight, S_IRUGO, bql_show_inflight, NULL);
>  
>  #define BQL_ATTR(NAME, FIELD)						\
>  static ssize_t bql_show_ ## NAME(struct netdev_queue *queue,		\

Acked-by: Eric Dumazet <eric.dumazet@...il.com>



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html