netdev - Re: [0/5] bcma/brcmsmac suspend/resume cleanups and fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+55aFxTkKwTy8mq9vRzHLNE7W8SYd5kbg2Ofr8LiG0DznLy6A@mail.gmail.com>
Date:	Sat, 14 Jan 2012 11:15:27 -0800
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Dominique Martinet <asmadeus@...ewreck.org>
Cc:	Arend van Spriel <arend@...adcom.com>,
	Rafał Miłecki <zajec5@...il.com>,
	Larry Finger <Larry.Finger@...inger.net>,
	Alwin Beukers <alwin@...adcom.com>,
	Roland Vossen <rvossen@...adcom.com>,
	"John W. Linville" <linville@...driver.com>,
	Network Development <netdev@...r.kernel.org>,
	"Franky (Zhenhui) Lin" <frankyl@...adcom.com>
Subject: Re: [0/5] bcma/brcmsmac suspend/resume cleanups and fixes

On Sat, Jan 14, 2012 at 4:22 AM, Dominique Martinet
<asmadeus@...ewreck.org> wrote:
>
> Sorry to hijack this thread, but I had the exact same problem Arend has
> and disabling MCE fixed it.. Since it froze only after resume and it
> didn't send anything to netconsole at this moment I've had this for some
> time without any good debug info, so first is a thank you!
>
> I'd like to try if the fix in current -git works, could you remind me
> the exact tree name you call this?


  git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux

is the main tree. The old "linux-2.6" name is just a symlink alias to it.

The commit that should fix MCE is just a oneliner: commit a3301b751b19
("x86/mce: Fix CPU hotplug and suspend regression related to MCE").

> I'm familiar with linux-2.6.git, wireless-testing.git, and
> linux-next.git, but it's not resolved in linux-next.git not
> linux-2.6.git's HEAD at the very least.

If it's not resolved in linux-2.6, then you have a different problem.

Or, possibly, the mirroring hadn't quite happened yet when you fetched
it - so it's worth double-checking that you have that commit
a3301b751b19 in your tree. But kernel.org git mirroring has been
pretty fast now that it uses gitorious.

> By the way, resume/suspend works with your patches over linux-next.git
> with a bcm4313 on a eeepc1215b!

Good. So they probably didn't break anything. It's always hard to tell
with drivers: even if it's an "obvious fix", the old code may have
worked for random reasons, and fixing it then breaks.

But I do think the patches should be pretty safe. The PCI layer
generally does all the PCI-level suspend/resumes correctly, and
drivers that try to do it are more likely to mess it up than not (that
didn't use to be true long ago, which is why many drivers still do it
- legacy baggage).

                           Linus
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html