netdev - Re: [PATCH 2/3] sha512: reduce stack usage to safe number

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACVxJT_+YZhK2oMU+iDKi_t_rMTarzrTh34Jqi1gPMicyf4=rw@mail.gmail.com>
Date:	Mon, 16 Jan 2012 12:20:47 +0200
From:	Alexey Dobriyan <adobriyan@...il.com>
To:	David Laight <David.Laight@...lab.com>
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	Herbert Xu <herbert@...dor.apana.org.au>,
	linux-crypto@...r.kernel.org, netdev@...r.kernel.org,
	ken@...elabs.ch, Steffen Klassert <steffen.klassert@...unet.com>,
	Eric Dumazet <eric.dumazet@...il.com>, security@...nel.org
Subject: Re: [PATCH 2/3] sha512: reduce stack usage to safe number

On 1/16/12, David Laight <David.Laight@...lab.com> wrote:
> Doesn't this badly overflow W[] ..
>
>> +#define SHA512_0_15(i, a, b, c, d, e, f, g, h) \
>> +	t1 = h + e1(e) + Ch(e, f, g) + sha512_K[i] + W[i];	\
> ...
>> +	for (i = 0; i < 16; i += 8) {
> ...
>> +		SHA512_0_15(i + 7, b, c, d, e, f, g, h, a);
>> +	}

No, why should it?
i can be only 0 and 8.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html