netdev - Re: [PATCH] bridge: BH already disabled in br_fdb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120116075349.2e9bf1e1@nehalam.linuxnetplumber.net>
Date:	Mon, 16 Jan 2012 07:53:49 -0800
From:	Stephen Hemminger <shemminger@...tta.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	Štefan Gula <steweg@...il.com>,
	"David S. Miller" <davem@...emloft.net>,
	netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH] bridge: BH already disabled in br_fdb_cleanup()

On Mon, 16 Jan 2012 15:35:50 +0100
Eric Dumazet <eric.dumazet@...il.com> wrote:

> br_fdb_cleanup() is run from timer interrupt, BH already masked.
> 
> Signed-off-by: Eric Dumazet <eric.dumazet@...il.com>
> CC: Stephen Hemminger <shemminger@...tta.com>
> CC: Štefan Gula <steweg@...il.com>
> ---
>  net/bridge/br_fdb.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/net/bridge/br_fdb.c b/net/bridge/br_fdb.c
> index f963f6b..5ba0c84 100644
> --- a/net/bridge/br_fdb.c
> +++ b/net/bridge/br_fdb.c
> @@ -146,7 +146,7 @@ void br_fdb_cleanup(unsigned long _data)
>  	unsigned long next_timer = jiffies + br->ageing_time;
>  	int i;
>  
> -	spin_lock_bh(&br->hash_lock);
> +	spin_lock(&br->hash_lock);
>  	for (i = 0; i < BR_HASH_SIZE; i++) {
>  		struct net_bridge_fdb_entry *f;
>  		struct hlist_node *h, *n;
> @@ -162,7 +162,7 @@ void br_fdb_cleanup(unsigned long _data)
>  				next_timer = this_timer;
>  		}
>  	}
> -	spin_unlock_bh(&br->hash_lock);
> +	spin_unlock(&br->hash_lock);
>  
>  	mod_timer(&br->gc_timer, round_jiffies_up(next_timer));
>  }
> 
> 

Acked-by: Stephen Hemminger <shemminger@...tta.com>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html