netdev - Re: [PATCHv2 net] net: WARN if skb_checksum_help() is called on skb requiring segmentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20120117.154912.944088870403029424.davem@davemloft.net>
Date:	Tue, 17 Jan 2012 15:49:12 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	bhutchings@...arflare.com
Cc:	netdev@...r.kernel.org, herbert@...dor.hengli.com.au
Subject: Re: [PATCHv2 net] net: WARN if skb_checksum_help() is called on
 skb requiring segmentation

From: Ben Hutchings <bhutchings@...arflare.com>
Date: Tue, 17 Jan 2012 17:57:56 +0000

> skb_checksum_help() has never done anything useful with skbs that
> require segmentation.  Setting skb->ip_summed = CHECKSUM_NONE makes
> them invalid and provokes a later WARNing in skb_gso_segment().
> 
> Passing such an skb to skb_checksum_help() indicates a bug, so we
> should warn about it immediately.  Move the warning from
> skb_gso_segment() into a shared function, and add gso_type and
> gso_size to it.
> 
> Signed-off-by: Ben Hutchings <bhutchings@...arflare.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html